ECE redirects - SAML sign outgoing messages #2012
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
I'd leave the old URL because it was valid with underscores in the 3.7 ECE docs: https://www.elastic.co/guide/en/cloud-enterprise/3.7/ece_sign_outgoing_saml_message.html not sure what happened with 3.8 but would leave it alone to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds https://www.elastic.co/guide/en/cloud-enterprise/current/ece-sign-outgoing-saml-message.html to the appropriate doc as a mapped_page.
This is part of the work for https://github.com/elastic/docs-projects/issues/494
In a parallel activity we will request the redirect of that page to https://www.elastic.co/docs/deploy-manage/users-roles/cluster-or-deployment-auth/saml#_configuring_es_for_signing
In this case I think the problem was caused by a typo (
_instead of-). We already had this redirection and mapped_page configured, which is probably wrong:https://www.elastic.co/guide/en/cloud-enterprise/current/ece_sign_outgoing_saml_message.html
I believe there's a typo and we could remove the redirection and the mapped_page of the underscored case. But I won't be doing it until I get confirmation from @colleenmcginnis or @shainaraskas .
@shainaraskas : I have also added a small update in the SAML doc as all the links about
custom bundlesneed to be separated between ECH and ECE, because the procedures are completely different. let me know your thoughts and if you want to change the wording.